Skip to content

Add Marijn Schouten to .mailmap #148030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Add Marijn Schouten to .mailmap #148030

merged 1 commit into from
Oct 24, 2025

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Oct 23, 2025 •
edited
Loading

Should fix rust-lang/thanks#85

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lqd
Copy link
Member

lqd commented Oct 23, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 23, 2025

📌 Commit 41b4b2f has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#148030 - hkBst:patch-3, r=lqd
2d07dd5 
Add Marijn Schouten to .mailmap

Should fix rust-lang/thanks#85
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 23, 2025
Closed
bors added a commit that referenced this pull request Oct 23, 2025
@bors
Auto merge of #148041 - matthiaskrgr:rollup-ysofz8z, r=matthiaskrgr
72fab81 
Rollup of 3 pull requests

Successful merges:

 - #148018 (fix panic when rustc tries to reduce intermediate filenames len with utf8)
 - #148030 (Add Marijn Schouten to .mailmap)
 - #148039 (Add myself to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 23, 2025

⌛ Testing commit 41b4b2f with merge 27050c0...

@bors
Copy link
Collaborator

bors commented Oct 24, 2025

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 27050c0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 24, 2025
@bors bors merged commit 27050c0 into rust-lang:master Oct 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 24, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6501e64 (parent) -> 27050c0 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 27050c0d15af664cf43ce4b0badec230e0bfcac5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 13800.0s -> 8112.1s (-41.2%)
  2. dist-aarch64-apple: 7480.5s -> 6416.5s (-14.2%)
  3. dist-x86_64-apple: 7494.8s -> 6592.8s (-12.0%)
  4. dist-various-1: 3727.6s -> 4148.7s (11.3%)
  5. x86_64-mingw-1: 9031.0s -> 9945.3s (10.1%)
  6. aarch64-msvc-1: 7155.3s -> 6464.2s (-9.7%)
  7. dist-powerpc64le-linux-musl: 5761.4s -> 5236.6s (-9.1%)
  8. dist-i686-msvc: 7763.9s -> 8440.3s (8.7%)
  9. dist-x86_64-msvc-alt: 8621.8s -> 9293.7s (7.8%)
  10. x86_64-gnu-llvm-20: 2396.4s -> 2561.8s (6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (27050c0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.2%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.2% [4.2%, 4.2%] 1
Improvements ✅
(primary)		 -1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 1

Cycles

Results (primary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.8% [-3.8%, -3.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.496s -> 474.745s (-0.37%)
Artifact size: 390.49 MiB -> 390.51 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

I'm listed twice

6 participants

@hkBst @rustbot @lqd @bors @rust-timer @Mark-Simulacrum